Work Instruction Editing Backend Logic Overhaul, DTOs for the Phoebe Work Instruction Editor#151
Merged
EyeBrawler merged 27 commits intomainfrom Mar 3, 2026
Merged
Work Instruction Editing Backend Logic Overhaul, DTOs for the Phoebe Work Instruction Editor#151EyeBrawler merged 27 commits intomainfrom
EyeBrawler merged 27 commits intomainfrom
Conversation
* Removal based on the logic that summary DTOs should not be used to create entities.
…estSummariesAsync, GetFormByIdAsync, and DeleteNodesAsync (that accepts ids).
…ement Side Panel in Phoebe
…Node File DTOs. Calls are made to child mapper methods.
…ames and numbers together for export with the PartNodeFileDTO
* Some bugs are present, such as products not keeping there associations. * This commit integrates various DTOs into the codebase such as the WorkInstructionFormDTO, the WorkInstructionSummaryDTO, and the ProductDetailDTO. * Import and export now uses the WorkInstructionFileDTO and import no longer saves the work instruction to the database, only loads it in memory.
…InstructionFormDTOs
…onService from the ProductService
…rt Definitions. These fixes will be made obsolete with DTOs here in the future.
…FormDTOs for Code Clarity. ToEntity() does indeed make a new entity, which can cause tracking issues on update.
…ired on Initialization. Should help mitigate EF tracking issues.
…ructionUpdater Class (utilizing dependency injection). Should fix many of the work instruction save errors.
… WorkInstructionService and WorkInstructionEditorService tests.
…vice's SaveAsync method.
…for Code Clarity. Small naming tweaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
This pull request features a complete refactor of the Phoebe Work Instruction Editor to utilize data transfer objects (DTOs).
It also includes a complete rewrite of work instruction updating logic, which should be much more robust and less error prone.
No database migrations are required.