Work Instruction Editor Save Logic Overhaul, Database Schema Additions, Updated Import and Export#170
Merged
EyeBrawler merged 85 commits intomainfrom Mar 16, 2026
Merged
Conversation
…n work instructions are cloned for a new version.
…ializablePartRelationship. Adding extra navigation properties to the SerializablePart for convenience.
…k Instruction (bug fix)
…log (and then menu bar) after import.
… checks are done after a work instruction is imported as it is loaded into memory only.
…ap DTOs. It does not resolve any parts.
…ution will now have to occur during save.
… Component. Also, swapping part name and number positions in the node.
…er inherits from IPartNodeResolver
…abase for products, just collects product names.
…. Adding a product resolver service to resolve products at save time.
…es are also loaded
…. Allows renaming parameter was not being set in MenuBarPhoebe.razor
… selected by default
…uction export function
…kInstructionService to all use the centralized PartDefinitionResolver service.
…t Definition Names in the WorkInstructionFormDTO
…ced parts, resolution happens in the service layer.
… sure that the part node resolver does not use its own DBContext.
… resolver (to get rid of syntax errors)
…n Duplicate Constraints. Part definitions can no longer share names. No two work instructions can have the same title and version strings." This reverts commit 12c56f2.
This reverts commit 6450b4b.
This reverts commit 0c567ef.
This reverts commit 675aca4.
This reverts commit 4ce6e8f
…ype. (called PartNameWithNumberAndInputType)
… Types. Supported Formats * PART_NAME * (PART_NAME) * (PART_NAME, PART_NUMBER) * (PART_NAME, PART_NUMBER, INPUT_TYPE)
…ges before searching the database to make new part definition objects.
… see if new part definitions need to be made for products.
…WorkInstruction Entity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
Spreadsheet import and export now supports...
(PART_NAME, PART_NUMBER, INPUT_TYPE)INPUT_TYPEareSerial,ProductionLogId, andTag.User Import and Export
New Tables in the Database Schema (with models and some DTOs)
FailureAdjective(for describing a failed attempt)FailureNoun(for specifying what part in a step failed)FailureNounAdjectives(To store relationships between failure nouns and adjectives)SerializablePartRelationship(to explicitly store the relationships between parts)Tags(a model to store data for reusable tags for part traceability)TagHistories(stores the history of reusable tags)Note: The services and UI do not support these tables yet, that will come in a later pull request.
Bug Fixes
This pull request features a complete overhaul of work instruction save logic. New resolution services (such as the
ProductResolver,PartNodeResolver, and thePartDefinitionResolverhave been added to more intelligently link work instruction data to existing entities without creating new ones. This significantly improves the integrity of data persisted by the work instruction editor and its reliability.Note: Data validation in the services still needs more work at this point, especially concerning work instructions and parts with duplicate names and/or version tags.