Photodiode example (FDTD) #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exilief
force-pushed
the
photodiode-example
branch
from
1f614ed to
7034315
Compare
Contributor
Author
|
I now added basic CMake support to my library. The user must manually download and install it and add it to CMake's search paths when building ViennaPS with examples. It should then be found by |
exilief
force-pushed
the
photodiode-example
branch
from
7034315 to
84385fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a photodiode example that utilizes my FDTD library for postprocessing, so it must be decided how it should be linked. You may decide to also make a fork of my library for maintenance.
To ensure a correct version is used, should the build system include it as an optional dependency, or does the user have to manually install it and make it available? Is there an example where such a case is already handled?
A similar issue is present for the Eigen library used in the ViennaCS diffusion example, see the PR.