Include InlineTemplate by default in Base #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelhawksley
commented
Jun 23, 2023
joelhawksley
commented
Jun 23, 2023
BlakeWilliams
approved these changes
Jun 23, 2023
Contributor
BlakeWilliams
left a comment
BlakeWilliams
left a comment
There was a problem hiding this comment.
LGTM
I think we should consider shipping a rubocop linter to enforce single quoted heredocs along with this change, but I'll defer to you on that one.
joelhawksley
commented
Jun 23, 2023
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
* Include InlineTemplate by default in Base * handle uninitialized ivar * do not worry about coverage of codestats rake task * Update docs/guide/templates.md
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
* Include InlineTemplate by default in Base * handle uninitialized ivar * do not worry about coverage of codestats rake task * Update docs/guide/templates.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to include this module by default ❤️
I also included a fix to ignore coverage of a minor rake task that has been flaky in CI.