[v4] Remove unnecessary #format definitions, which returned nil#2233
Merged
joelhawksley merged 1 commit intov4from Mar 20, 2025
Merged
[v4] Remove unnecessary #format definitions, which returned nil#2233joelhawksley merged 1 commit intov4from
joelhawksley merged 1 commit intov4from
Conversation
joelhawksley
force-pushed
the
no-format-needed
branch
from
ee9b7e4 to
1dba7ad
Compare
joelhawksley
force-pushed
the
no-format-needed
branch
from
1dba7ad to
1ba42b7
Compare
joelhawksley
changed the title
tiagomenegaz
approved these changes
Mar 19, 2025
Collaborator
tiagomenegaz
left a comment
tiagomenegaz
left a comment
There was a problem hiding this comment.
Approved based on the context provided and the non-breaking changes. Feel free to wait for @BlakeWilliams review if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR looks to close #1973 by removing our definition of
#formatmethods, as:nilanyways.We can always revisit adding them back if needed, which I don't think would be a breaking change.