Skip to content

Prove broken ci #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joelhawksley wants to merge 2 commits into from
Closed

Prove broken ci #2555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9ce5ac
is CI broken?
joelhawksley Feb 12, 2026
174445b
this code path is never reached
joelhawksley Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ nav_order: 6
# Changelog

## main

* Fix segfault when Ruby coverage is enabled but template annotations are disabled.

*George Holborn*
Expand Down
1 change: 1 addition & 0 deletions lib/view_component/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ def compiled_source
# Strip the annotation line to maintain correct line numbers when coverage
# is running (avoids segfault from negative lineno)
result = result.sub(/\A[^\n]*\n/, "") if @strip_annotation_line
raise if @strip_annotation_line
result
end
end
Expand Down
Loading