3 x security backports#2650
Merged
Merged
Conversation
- Force-load CGI in sandbox boot.rb so @@accept_charset is defined on CGI before globalid's Railtie calls CGI.unescape (avoids C extension crash on Ruby 3.5). - Remove the ineffective cgi < 0.5 pin from Gemfile, Appraisals, and all generated gemfiles; the explicit require is the actual fix. - Skip test_render_inline_allocations on prerelease Rails (main): the allocation count fluctuates day-to-day with upstream churn.
`appraisal generate` baked "ruby ~> 3.4" into each gemfile from the parent Gemfile's `ruby ruby_version` declaration. This caused Bundler to fail in CI for Ruby 3.0/3.1/3.2/3.3 jobs (the CI matrix sets Ruby via ruby/setup-ruby@v1, not via the Gemfile).
Nokogiri 1.19.3 (current latest) ships precompiled binaries for ABIs 3.2/3.3/3.4 but not 3.5. Setting BUNDLE_FORCE_RUBY_PLATFORM=true on the Ruby 3.5 jobs makes Bundler install the platform-agnostic gem so it builds from source against the system libxml/libxslt.
The require "cgi" added in 938ebda (to fix the Ruby 3.5 globalid crash) adds one extra allocation during the first render. Bump the expected counts on Ruby 3.5: 119->120 (Rails 8.0) and 117->118 (Rails 8.1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?