Skip to content

Fix bug rendering component collections from controllers #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 15, 2020
Merged

Fix bug rendering component collections from controllers #554

merged 7 commits into from
Dec 15, 2020

Conversation

@joelhawksley
Copy link
Member

@joelhawksley joelhawksley commented Dec 15, 2020

Fixes #549.

@joelhawksley joelhawksley marked this pull request as ready for review December 15, 2020 17:14
BlakeWilliams
BlakeWilliams approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@BlakeWilliams BlakeWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@joelhawksley joelhawksley merged commit b033b4c into master Dec 15, 2020
@joelhawksley joelhawksley deleted the 549-collection-private-method-format branch December 15, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BlakeWilliams BlakeWilliams BlakeWilliams approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NoMethodError (private method `format' called)

3 participants

@joelhawksley @BlakeWilliams