fix(file): remove unnecessary margin and fix error when no guiding text is provided #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st is provided. close VilledeMontreal#117. Signed-off-by: Maude LAFLAMME <maude.laflamme@montreal.ca>
Contributor
|
@MaudeLaflamme Peux-tu créer un build dans chromatic pour que je puisse regarder ça? |
Collaborator
Author
|
@gregpetit C'est fait! |
OlivierAlbertini
approved these changes
Jan 19, 2023
Member
|
ne pas oublier la PR pour master (Angular 14) Peut être mettre le close #117 dans la PR pour Angular 14 |
gregpetit
requested changes
Jan 19, 2023
Contributor
gregpetit
left a comment
gregpetit
left a comment
There was a problem hiding this comment.
@MaudeLaflamme J'ai mis mes commentaires dans Chromatic pour essayer. Laisse-moi savoir si c'est correct ou si tu préfères qu'on fasse ça dans GitHub comme d'habitude.
sori-ard
approved these changes
Jan 19, 2023
Collaborator
Author
|
@gregpetit C'est bien les commentaires sur Chromatic! J'y ai répondu |
Collaborator
Author
|
@gregpetit Est-ce qu'il y avait d'autres changements que tu demandais, outre les bugs dans la composante Summary? |
Contributor
|
Non, tout est beau! |
gregpetit
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voir issue #117
Fix du premier bug:
Fix du deuxième bug:
