feat(system-header): add system-header pattern. close #55 #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MaudeLaflamme
commented
May 24, 2023
MaudeLaflamme
commented
gregpetit
requested changes
May 25, 2023
Contributor
gregpetit
left a comment
gregpetit
left a comment
There was a problem hiding this comment.
- La style du texte des infos supplémentaires n'est pas le bon. Ça devrait être le style "Small-Regular (font-size: 14px ; line-height : 20px)
- Sur mobile, l'info supplémentaire devrait se retrouver sous le tag, avec 4px d'espacement entre les deux (le point de séparation n'est plus présent).
MaudeLaflamme
force-pushed
the
feature/add-system-header
branch
from
a8873d1 to
77dc891
Compare
Collaborator
Author
|
@gregpetit |
gregpetit
approved these changes
May 26, 2023
MaudeLaflamme
force-pushed
the
feature/add-system-header
branch
from
fead478 to
877fc5b
Compare
mtlmatt
pushed a commit
that referenced
this pull request
Aug 4, 2023
mtlmatt
pushed a commit
to mtlmatt/angular-ui
that referenced
this pull request
Aug 4, 2023
(VilledeMontreal#171) Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca> # Conflicts: # projects/angular-ui/src/public-api.ts
mtlmatt
pushed a commit
to mtlmatt/angular-ui
that referenced
this pull request
Aug 4, 2023
(VilledeMontreal#171) Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
mtlmatt
pushed a commit
to mtlmatt/angular-ui
that referenced
this pull request
Aug 4, 2023
(VilledeMontreal#171) Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
mtlmatt
pushed a commit
to mtlmatt/angular-ui
that referenced
this pull request
Aug 4, 2023
(VilledeMontreal#171) Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
mtlmatt
pushed a commit
to mtlmatt/angular-ui
that referenced
this pull request
Aug 4, 2023
(VilledeMontreal#171) Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
mtlmatt
pushed a commit
to mtlmatt/angular-ui
that referenced
this pull request
Aug 4, 2023
(VilledeMontreal#171) Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
mtlmatt
pushed a commit
to mtlmatt/angular-ui
that referenced
this pull request
Aug 4, 2023
(VilledeMontreal#171) Signed-off-by: Maude Laflamme <33531625+MaudeLaflamme@users.noreply.github.com>
mtlmatt
pushed a commit
to mtlmatt/angular-ui
that referenced
this pull request
Aug 4, 2023
(VilledeMontreal#171) Signed-off-by: MaudeLaflamme <33531625+MaudeLaflamme@users.noreply.github.com>
mtlmatt
pushed a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.