feat: add pagination component #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaudeLaflamme
requested review from
OlivierAlbertini and
gregpetit
and removed request for
OlivierAlbertini and
gregpetit
MaudeLaflamme
force-pushed
the
feature/pagination-component
branch
5 times, most recently
from
8fae964 to
0a4bf19
Compare
gregpetit
requested changes
Oct 3, 2025
Contributor
gregpetit
left a comment
gregpetit
left a comment
There was a problem hiding this comment.
Quelques changements è faire :
- Le style de focus devrait être à l'intérieur des boutons de page, pas à l'extérieur.
- Le style de texte des 3 petits points devrait être en gras, et non pas normal.
- Le style du sélecteur est celui par défaut en HTML. Voir si on peut appliquer le style de la librairie.
- L'espacement entre "Items par page" et le sélecteur doit être de 16px
- L'espacement entre la partie pagination et la partie du haut (sélecteur et nombre d'item) devrait être de 16px, pas 0px.
- Quand le bouton de flèche gauche ou droit est désactivé, le style visuel désactivé n'est pas appliqué.
- Il manque aussi les espacements verticaux entre les 3 parties dans la version mobile.
IsmaylRahmaoui
approved these changes
Oct 6, 2025
MaudeLaflamme
force-pushed
the
feature/pagination-component
branch
from
d4a7542 to
13745cc
Compare
Collaborator
Author
|
@gregpetit je viens de pousser un build sur chromatic avec les changements. |
IsmaylRahmaoui
approved these changes
Oct 6, 2025
gregpetit
requested changes
Oct 7, 2025
Contributor
gregpetit
left a comment
gregpetit
left a comment
There was a problem hiding this comment.
Tout est fixé à part le style des boutons avec chevron lorsqu'ils sont désactivés.
Le style est disponible ici : https://www.figma.com/design/Ijmyha6Ag2VFZUmEBNBQXwpZ/VDM---Librairie?node-id=25974-20558&t=R4srFwr7SKyKhAfw-11
Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>
MaudeLaflamme
force-pushed
the
feature/pagination-component
branch
from
13745cc to
c1ef780
Compare
gregpetit
approved these changes
Oct 7, 2025
Dorikob
pushed a commit
to Dorikob/angular-ui
that referenced
this pull request
Dec 2, 2025
Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca> Co-authored-by: uleoner <ericandre.leon-rodas@montreal.ca>
Dorikob
pushed a commit
to Dorikob/angular-ui
that referenced
this pull request
Dec 2, 2025
Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca> Co-authored-by: uleoner <ericandre.leon-rodas@montreal.ca> Signed-off-by: bk <100145265+Dorikob@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.