[Bug]: Diff view fails and stops working on an edge-case

[shumadrid]

Describe the bug

if you try to open a diff view of a file that's actually a nested repository (not a sub module), this plugin will throw an unhandled error, and then afterwards the diff view won't load any other files that you want to open.

A reload of the plugin is needed to reset this.

It's because only certain errors are handled in the gitShow function and others are just thrown and not being handled anywhere. (Is this intentional?)

Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)

Steps to reproduce

1. Move a git repo inside your vault.
2. Commit it a few times.
3. Try to open it with the diff view.

Expected Behavior

No response

Addition context

I've done a bit of research on if there's a easy efficient git way to detect if any of the committed objects are actually a git repository, or other bad things like symlinks, but didn't find anything simple.

Operating system

macOS

Installation Method

None

Plugin version

2.31.1

[shumadrid]

Update: I've done some inspecting of this plugin code and i don't see any explicit error handling for the git.raw() function, yet it still gets handled by this plugin and doesn't propagate to my plugin. (I am interacting with git through this plugin, not very familiar with simple-git)

I've done some digging and found the custom "errors" property of the simple git instance that this plugin doesn't define, and which would be useful to configure for running commands like isAncestor and getting any kind of response.

A separate .raw() function which can be excluded from any error handling could be introduced, intended for other plugins to use. (There are benefits to interacting with git through a single point, rather than every plugin running its own simple git instance)

Would you be open to implementing this?

The exact thing i'm trying to do is: on file open, open that file history (git log), but when user opens any newly created file, it isnt in the git repo yet and Im unable to handle it gracefully bc this plugin handles the fatal error thrown by git (just stops working), and i noticed this is the primary behaviour when handling any error from any function that isn't run from the UI (intended probably?)

[Vinzent03]

Thanks for your contribution! I'm not entirely sure about your situation. There should be no error handling from my side if you call git.raw(). You should be able to catch them just fine or additionally pass a handle function, which should get the error as well.

But I see the issue that the raw function doesn't throw if the stderr is empty, but is exit code is non-zero. I will test the solution in your linked issue and see if it causes any side effects.

[shumadrid]

That is weird, I do remember trying out everything i could, from passing a handle function to trying to intercept as early as possible.

[Vinzent03]

With a quick test in the console, you should be able to catch them just fine:

[shumadrid]

Maybe there is some special handling only for "fatal" errors inside simple-git?
But it doesn't matter to me now, since i worked around this.

If it comes up in the future i will investigate what i was doing wrong.