Skip to content

feat: enhance static file analysis (PAR-2226)#82

Merged
robaone-redshelf merged 23 commits into
developfrom
ar-PAR-2226-scan-all-workflow-and-action-yml-files
Apr 6, 2025
Merged

feat: enhance static file analysis (PAR-2226)#82
robaone-redshelf merged 23 commits into
developfrom
ar-PAR-2226-scan-all-workflow-and-action-yml-files

Conversation

@robaone-redshelf
Copy link
Copy Markdown
Contributor

@robaone-redshelf robaone-redshelf commented Apr 4, 2025

Ticket:

https://virdocs.atlassian.net/browse/PAR-2226

Changes: (complexity: high)

This PR enhances the static analysis GitHub Action with two main improvements:

YAML Scanning Enhancements

  • Expanded scanning to include both .github/workflows and all .github directories in domain folders
  • Improved warning outputs using GitHub Workflow Commands for better visualization
  • Added error handling for missing directories
  • Added step IDs and controlled error propagation with continue-on-error flags

New Layer Dependency Analysis

  • Added new functionality to compare package.json dependencies between layers and domains
  • Ensures consistent dependency versions between related packages
  • Highlights and reports version mismatches as warnings in GitHub workflows
  • Added new inputs to specify layer package.json path and domains to analyze

These improvements help maintain code quality and dependency consistency across the entire repository structure.

@robaone-redshelf
Copy link
Copy Markdown
Contributor Author

Successfully created warnings in github actions
image

@robaone-redshelf
Copy link
Copy Markdown
Contributor Author

Successfully tested layer missmatch
image

@mattsredshelf
Copy link
Copy Markdown
Contributor

This looks great and will be a big help!

@robaone-redshelf robaone-redshelf merged commit e41e552 into develop Apr 6, 2025
@robaone-redshelf robaone-redshelf deleted the ar-PAR-2226-scan-all-workflow-and-action-yml-files branch April 6, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants