Skip to content
This repository was archived by the owner on Feb 20, 2024. It is now read-only.

Feat/pagination compensations#11

Merged
lsipii merged 10 commits into
mainfrom
feat/pagination-compensations
Dec 5, 2022
Merged

Feat/pagination compensations#11
lsipii merged 10 commits into
mainfrom
feat/pagination-compensations

Conversation

@lsipii
Copy link
Copy Markdown
Contributor

@lsipii lsipii commented Dec 1, 2022

  • compensates the pagination so that when asking a 10 items the API responds with a 10
  • changes the frontend request input pagination signature:
 "paging": {
    "items_per_page": 10,
    "page_number": 0
  }

@lsipii lsipii requested a review from LauriGofore December 1, 2022 14:06
LauriGofore
LauriGofore approved these changes Dec 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@LauriGofore LauriGofore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lsipii lsipii merged commit 51b0c0a into main Dec 5, 2022
@lsipii lsipii deleted the feat/pagination-compensations branch December 15, 2022 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@LauriGofore LauriGofore LauriGofore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lsipii @LauriGofore