Conversation
LauriGofore
reviewed
Oct 16, 2023
| RuleFor(occupations => occupations) | ||
| .MustAsync(async (occupations, cancellationToken) => | ||
| { | ||
| var knownOccupations = await _occupationsFlatRepository.GetAllOccupationsFlat(); |
Contributor
There was a problem hiding this comment.
Lataakos nämä jostain muistista, ettei network requa tee joka kerta. (varmaan ite ollut tämän päällä joskus, ei muista 😅 )
e: no vähemmän laiskana kävin kurkkaa, niin kai se sinne jonnekin muistiin menee (tuolla oli joku TODO in-memory cachee liittyen.. mutta toiminnee)
Contributor
Author
There was a problem hiding this comment.
e: no vähemmän laiskana kävin kurkkaa, niin kai se sinne jonnekin muistiin menee (tuolla oli joku TODO in-memory cachee liittyen.. mutta toiminnee)
Joops tuo tieto tulee codesets-riippuvuudesta ja se repository säilöö asian lambda-instanssin elinajan verran, eli muistista muistelee. Ne TODO-merkinnät voisi ehkä käsitellä kanssa jossain kohti näitä siivoiluja..
lsipii
deleted the
VFD-174-parannetaan-users-api-n-endpointtien-data-validointia-occupations-ja-work-preferences-tietojen-osalta-2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateJobApplicantProfileproductizer operation:ErrorHandlerMiddleware: so those errors produce output match to the tesbed requirements as well..