Skip to content

Fix bad Terms-of-Service refactoring / merging#96

Merged
lsipii merged 2 commits intomainfrom
fix/tos-should-not-be-verified-on-check-phase
Oct 24, 2023
Merged

Fix bad Terms-of-Service refactoring / merging#96
lsipii merged 2 commits intomainfrom
fix/tos-should-not-be-verified-on-check-phase

Conversation

@lsipii
Copy link
Copy Markdown
Contributor

@lsipii lsipii commented Oct 23, 2023 •
edited
Loading

  • users-controllissa majailevan tossi-kyselyfunktion ei pitäisi varmistaa tossin hyväksyntää vaan ainoastaan palauttaa se:
    • heitti NotAuthorizedException jos tossia ei hyväksytty, kun olisi pitänyt vain palauttaa payloadi
    • kirjautumisflow herjaa punaista uusilla käyttäjillä jos tossi-varmistus on päällä
  • lisätty puuttuva testikeissi

@lsipii lsipii requested a review from LauriGofore October 23, 2023 13:06
LauriGofore
LauriGofore approved these changes Oct 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@LauriGofore LauriGofore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lsipii lsipii merged commit f1d1fe8 into main Oct 24, 2023
@lsipii lsipii deleted the fix/tos-should-not-be-verified-on-check-phase branch October 24, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LauriGofore LauriGofore LauriGofore approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lsipii @LauriGofore