Add MAC address replacement in URL pattern for transport updates#173
Merged
Conversation
aschumann-virtualcable
requested review from
janpenitent
and removed request for
dkmstr
janpenitent
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the URL generation logic in the
get_linkmethod to support substituting the user's MAC address into the URL pattern. This allows URLs to be customized with the user's unique hardware identifier, improving integration with systems that require MAC-based authentication or tracking.Enhancement to URL customization:
get_linkinurl_custom.pyto retrieve the user's unique MAC address usinguserservice.get_unique_id()and substitute it into the URL pattern by replacing the_MAC_placeholder.