refactor: @eslint/config-helpers ベースで設定をいじるようにする#510
Conversation
|
commit: |
✅ Snapshot test successSee the details: workflow run |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ESLint configuration to use @eslint/config-helpers instead of typescript-eslint for configuration management, aimed at removing typescript-eslint types from externally exposed type definitions.
- Replaces
tseslint.config()withdefineConfig()from@eslint/config-helpersacross all configuration files - Introduces a backward compatibility helper (
prepareForExtend) to handle differences in file inheritance behavior - Updates type annotations from typescript-eslint specific types to standard ESLint types
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/eslint-config/src/utils/eslint.ts | New utility file with backward compatibility helper for config extension |
| packages/eslint-config/src/presets/*.ts | Updated all preset files to use defineConfig instead of tseslint.config |
| packages/eslint-config/src/base/*.ts | Refactored base configuration files to use @eslint/config-helpers and standard ESLint types |
| packages/eslint-config/src/addons/*.ts | Updated addon configurations to use defineConfig |
| packages/eslint-config/package.json | Added dependencies for @eslint/config-helpers and defu |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
外部に公開される型定義に typescript-eslint の型が入ってくるのをやめたい