Skip to content

refactor: @eslint/config-helpers ベースで設定をいじるようにする#510

Merged
sushichan044 merged 8 commits intomainfrom
eslint-config-helper
Jul 18, 2025
Merged

refactor: @eslint/config-helpers ベースで設定をいじるようにする#510
sushichan044 merged 8 commits intomainfrom
eslint-config-helper

Conversation

@sushichan044
Copy link
Copy Markdown
Contributor

外部に公開される型定義に typescript-eslint の型が入ってくるのをやめたい

@sushichan044 sushichan044 requested a review from Copilot July 18, 2025 07:35
@sushichan044 sushichan044 self-assigned this Jul 18, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 18, 2025

⚠️ No Changeset found

Latest commit: 9226bff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the eslint issues about eslint label Jul 18, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jul 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@virtual-live-lab/eslint-config@510

commit: 9226bff

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 18, 2025

✅ Snapshot test success

See the details: workflow run

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the ESLint configuration to use @eslint/config-helpers instead of typescript-eslint for configuration management, aimed at removing typescript-eslint types from externally exposed type definitions.

  • Replaces tseslint.config() with defineConfig() from @eslint/config-helpers across all configuration files
  • Introduces a backward compatibility helper (prepareForExtend) to handle differences in file inheritance behavior
  • Updates type annotations from typescript-eslint specific types to standard ESLint types

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/eslint-config/src/utils/eslint.ts New utility file with backward compatibility helper for config extension
packages/eslint-config/src/presets/*.ts Updated all preset files to use defineConfig instead of tseslint.config
packages/eslint-config/src/base/*.ts Refactored base configuration files to use @eslint/config-helpers and standard ESLint types
packages/eslint-config/src/addons/*.ts Updated addon configurations to use defineConfig
packages/eslint-config/package.json Added dependencies for @eslint/config-helpers and defu
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread packages/eslint-config/src/utils/eslint.ts Outdated
Comment thread packages/eslint-config/src/base/typescript.ts
Comment thread packages/eslint-config/src/base/typescript.ts Outdated
Comment thread packages/eslint-config/src/base/react.ts
@sushichan044 sushichan044 merged commit 922cf03 into main Jul 18, 2025
8 checks passed
@sushichan044 sushichan044 deleted the eslint-config-helper branch July 18, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eslint issues about eslint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants