Incomplete working version of a modellist to mapping conversion function#122
Merged
Samuel-amap merged 12 commits intomainfrom Jan 17, 2025
Conversation
… work needed (see comments), but functional-ish
…o mapping test scenario. Previous TODOs still remaining (+ some initailisation issues)
…a check function to ensure the simulation graph is passed no vector in the statuses during creation
…od of naming conflicts
… are already handled. Extend a couple of tests to convert from modellist to mapping. TODO : multiscale testing
…ble newline ? Let's try that
Samuel-amap
commented
Jan 16, 2025
Collaborator
Author
There was a problem hiding this comment.
Looks like this does the trick. There were various links that discussed expression parsing (none of them super detailed about what constitutes an expression), but this one was about double newlines : https://discourse.julialang.org/t/meta-parse-failes-on-double-newlines/54272
…p... Make the function that checks whether vectors are still in mapping statuses return organ + boolean instead of asserting
Samuel-amap
deleted the
add-modellist-to-mapping-tests-+-automated-model-generation-from-vector
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modellist to mapping conversion function for tests, which will help for implementing output filtering on the modellist side
Add a convenience utility to generate models from status vector variables, which are currently handled in the modellist case but require an ad hoc model in the multiscale case