Skip to content

Filter out empty status vectors#160

Merged
Samuel-amap merged 1 commit intomainfrom
#138-outputs-conversion-failing-when-organ-is-not-created-but-requested-as-output
Oct 6, 2025
Merged

Filter out empty status vectors#160
Samuel-amap merged 1 commit intomainfrom
#138-outputs-conversion-failing-when-organ-is-not-created-but-requested-as-output

Conversation

@Samuel-amap
Copy link
Copy Markdown
Collaborator

Type deduction on outputs requires inspecting the first element of status vectors. Avoid doing so in cases where no organ was created and that vector is empty.

…atus vectors. Avoid doing so in cases where no organ was created and that vector is empty.
@Samuel-amap Samuel-amap merged commit 0bc9303 into main Oct 6, 2025
20 of 21 checks passed
@Samuel-amap Samuel-amap deleted the #138-outputs-conversion-failing-when-organ-is-not-created-but-requested-as-output branch October 6, 2025 15:00
@Samuel-amap Samuel-amap linked an issue Oct 6, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2025

Benchmark Results (Julia v1)

Time benchmarks
main b63e003... main / b63e003...
bench_linux/PBP 15.2 ± 1.9 ms 14.9 ± 1.7 ms 1.02 ± 0.17
bench_linux/PBP_multiple_timesteps_MT 0.281 ± 0.0079 s 0.277 ± 0.0044 s 1.01 ± 0.033
bench_linux/PBP_multiple_timesteps_ST 0.198 ± 0.039 s 0.19 ± 0.049 s 1.04 ± 0.34
bench_linux/PSE 4.25 ± 0.37 s 4.45 ± 0.44 s 0.956 ± 0.13
bench_linux/XPalm_convert_outputs 0.801 ± 0.063 s 0.794 ± 0.084 s 1.01 ± 0.13
bench_linux/XPalm_run 59.2 ± 20 s 58.7 ± 19 s 1.01 ± 0.47
bench_linux/XPalm_setup 14.6 ± 0.69 ms 14.6 ± 0.58 ms 0.998 ± 0.062
time_to_load 3.3 ± 0.0041 s 3.31 ± 0.014 s 0.996 ± 0.0045
Memory benchmarks
main b63e003... main / b63e003...
bench_linux/PBP 0.0892 M allocs: 5.36 MB 0.0892 M allocs: 5.36 MB 1
bench_linux/PBP_multiple_timesteps_MT 3.63 M allocs: 0.7 GB 3.63 M allocs: 0.7 GB 1
bench_linux/PBP_multiple_timesteps_ST 3.33 M allocs: 0.216 GB 3.33 M allocs: 0.216 GB 1
bench_linux/PSE 0.0496 G allocs: 2.3 GB 0.0497 G allocs: 2.31 GB 0.997
bench_linux/XPalm_convert_outputs 6.62 M allocs: 0.436 GB 6.62 M allocs: 0.436 GB 1
bench_linux/XPalm_run 0.573 G allocs: 28.9 GB 0.573 G allocs: 28.9 GB 1
bench_linux/XPalm_setup 0.169 M allocs: 9.13 MB 0.169 M allocs: 9.13 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issue when no organ is created for a scale

1 participant