Issue #7#14
Merged
AleMorales merged 1 commit intomasterfrom Jan 23, 2024
Merged
Conversation
- In all tutorials w/ trees> in treeparams swtiched the leaf_angle and branch_angle, change Node to TreeNode
- Tree tutorial, done!
- Forest, done!
- Growth forest, done!
- Notes:
- if 50 daily steps are used, the forest is bushy, maybe due to low #daily steps? Let’s increase!
- if 70 daily steps are used, the forest is still bush, even bushier! The internodes are smaller than leaves and some of the leaves and branches are growing into the soil layer.
- if 100 daily steps are used, Makie crashes, ups
- Ray-traced forest, done!
- create_sky updated in ray-traced forest!
- Need to release new version, else make a note to remind the user to update to master version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In all tutorials w/ trees> in treeparams switched the leaf_angle and branch_angle, changed Node to TreeNode
Growth forest, notes:
Function create_sky updated in ray-traced forest to integrate phi and theta!
Notes: Need to release new version, else make a note to remind the user to update to master version