Skip to content

fix: replace eslint-plugin-github with typescript-eslint for ESLint 10 compatibility#1087

Merged
tgodzik merged 2 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1084
Mar 24, 2026
Merged

fix: replace eslint-plugin-github with typescript-eslint for ESLint 10 compatibility#1087
tgodzik merged 2 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1084

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 24, 2026

eslint-plugin-github@6.0.0 (latest) declares peerDependencies: eslint@"^8 || ^9", making it incompatible with ESLint 10 and causing npm ci to fail with ERESOLVE.

Changes

  • Remove eslint-plugin-github — no version supports ESLint 10
  • Add typescript-eslint@^8.57.2 (unified package, supports ESLint ^8 || ^9 || ^10) as a direct replacement for the TypeScript flat config
  • Add globals@^17.4.0 as a direct dependency (was a transitive dep via eslint-plugin-github)
  • Update eslint.config.mjs — replace github.getFlatConfigs().typescript with tseslint.config(...tseslint.configs.recommended, ...)
-import github from "eslint-plugin-github";
+import tseslint from "typescript-eslint";

-export default [{
-    ignores: [...],
-}, ...github.getFlatConfigs().typescript, {
+export default tseslint.config({
+    ignores: [...],
+}, ...tseslint.configs.recommended, {
     // project-specific rules unchanged
-}];
+});

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Copilot AI changed the title [WIP] Bump eslint from 9.39.3 to 10.1.0 fix: replace eslint-plugin-github with typescript-eslint for ESLint 10 compatibility Mar 24, 2026
Copilot AI requested a review from tgodzik March 24, 2026 12:57
@tgodzik tgodzik marked this pull request as ready for review March 24, 2026 14:23
Copy link
Copy Markdown
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the other plugin indeed doesn't support esling 10

@tgodzik tgodzik merged commit fac3fc5 into dependabot/npm_and_yarn/eslint-10.1.0 Mar 24, 2026
5 checks passed
@tgodzik tgodzik deleted the copilot/sub-pr-1084 branch March 24, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants