-
Notifications
You must be signed in to change notification settings - Fork 7
Add action input for scala-cli version, default to latest #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action input for scala-cli version, default to latest #7
Conversation
lwronski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ptrdom, thanks for contribution.
IMO we shouldn't use the latest version of scala-cli by default. The user should be aware that there is a new version of scala-cli, test it and then merge it into the main branch. Without testing, it can generate unexpected behavior on CI
To keep the scala-cli-setup up to date, ScalaCli core team prepares a new task, to open PR with updating scala-cli version in scala-cli-setup. After release, this PR will be merged and created new tag. It will be something similar to the brew formula .
|
@lwronski All good, makes sense. I thought that defaulting to latest would not be a bad idea with the ability to set a specific version - developers should be quite used to getting the latest version with default installations. |
|
I think, you should also updated action.yml and specify new input parameter.
Right, but in some cases, it can throw an unexpected error, so it is better to test the newer version of Instead of the default behavior, maybe we should add support for the |
Will do.
Totally agree.
💯 |
…lue of scala-cli-version.
|
Hi @ptrdom, thanks again for contribution. Approved |
Add action input for scala-cli version, default to latest.