Skip to content

Conversation

@ptrdom
Copy link

@ptrdom ptrdom commented Apr 25, 2022

Add action input for scala-cli version, default to latest.

Copy link

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ptrdom, thanks for contribution.

IMO we shouldn't use the latest version of scala-cli by default. The user should be aware that there is a new version of scala-cli, test it and then merge it into the main branch. Without testing, it can generate unexpected behavior on CI

To keep the scala-cli-setup up to date, ScalaCli core team prepares a new task, to open PR with updating scala-cli version in scala-cli-setup. After release, this PR will be merged and created new tag. It will be something similar to the brew formula .

@ptrdom
Copy link
Author

ptrdom commented Apr 26, 2022

@lwronski All good, makes sense. I thought that defaulting to latest would not be a bad idea with the ability to set a specific version - developers should be quite used to getting the latest version with default installations.

@lwronski
Copy link

I think, you should also updated action.yml and specify new input parameter.

developers should be quite used to getting the latest version with default installations

Right, but in some cases, it can throw an unexpected error, so it is better to test the newer version of scala-cli-setup in PR and then merge after CI is passed.

Instead of the default behavior, maybe we should add support for the scala-cli-version which accepts value latest. In this approach, users have to specify explicitly using the latest version of scala-cli.

@ptrdom
Copy link
Author

ptrdom commented Apr 26, 2022

I think, you should also updated action.yml and specify new input parameter.

Will do.

developers should be quite used to getting the latest version with default installations

Right, but in some cases, it can throw an unexpected error, so it is better to test the newer version of scala-cli-setup in PR and then merge after CI is passed.

Totally agree.

Instead of the default behavior, maybe we should add support for the scala-cli-version which accepts value latest. In this approach, users have to specify explicitly using the latest version of scala-cli.

💯

@lwronski
Copy link

Hi @ptrdom, thanks again for contribution. Approved

@lwronski lwronski merged commit 156a3cf into VirtusLab:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants