Support for .test.java#4261
Merged
Merged
Conversation
Gedochao
force-pushed
the
feature/test-dot-java
branch
from
5c08fbc to
865857f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4245
This adds full support of
*.test.javainputs being recognised as test scope sources, automatically.As public classes in Java inputs have to be in
PublicClassName.javasources, arbitrarily, Scala CLI generates aPublicClassName.javasource out of aPublicClassName.test.javaunder the hood to makejavachappy. It's a bit hacky, but I think it's worth it for the consistent UX.Checklist
scala-cli fmt .)scalafix(./mill -i __.fix)How much have your relied on LLM-based tools in this contribution?
Extensively, Cursor + Claude
How was the solution tested?
included unit and integration tests for all the ways a Java input can be classified as a test scope source (directive,
.test.java,testdir)