feat(builder): add having filter builder#359
Merged
youngwinds merged 9 commits intomainfrom Mar 4, 2026
Merged
Conversation
- Add HavingBuilder for filter management - Add HavingFilterNodeBuilder for individual filter configuration - Support operators: eq, neq, gt, gte, lt, lte, contains, startsWith, endsWith, between - Add validation and error handling - Integrate with VBIBuilder This enables BI users to filter data based on conditions.
- Add Having.ts type definition for aggregation filtering - Update QueryDSL to include having field - Add buildHaving in VBI pipeline This enables Having filter to work end-to-end from VBI to VQuery.
- Add Having type implementation in sql-builder - Add applyHaving function for SQL generation - Integrate having with DSL to SQL pipeline - Add comprehensive unit tests (16 test cases) This enables having filter to work end-to-end from VBI to generated SQL.
- Add basic having example test - Add multi-conditions having test (AND) - Add or-conditions having test (OR) - All 142 tests passing
Use pnpm run g to generate test files from JSON configs
- Add min/max aggregation tests - Add not between test - Improve coverage to 99%+ Tests: 145 passed
- Add more having tests including nested groups - Add VQuery error handling tests - Coverage: 99.05% statements, 91.66% branches Tests: 148 passed
- Add not-in.json/test.ts - Add in-single.json/test.ts - Add not-in-single.json/test.ts - Coverage: 100% statements, 93.75% branches, 100% functions, 100% lines Tests: 151 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables BI users to filter data based on conditions.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
☑️ Self-Check before Merge