Skip to content

[codex] improve vbi test coverage#441

Merged
youngwinds merged 2 commits intomainfrom
codex/vbi-test-coverage
Apr 13, 2026
Merged

[codex] improve vbi test coverage#441
youngwinds merged 2 commits intomainfrom
codex/vbi-test-coverage

Conversation

@youngwinds
Copy link
Copy Markdown
Collaborator

Summary

  • add focused internal tests for VBI chart/report/insight helpers, resource stores, date predicate resolution, and utility export paths
  • cover report snapshot, schema lookup, UUID guards, and collection helper branches that were previously untested
  • update the root coverage badge after raising @visactor/vbi coverage to about 99.31% statements/lines and 94.13% branches

Why

The existing VBI test suite covered the main builder flows well, but several small internal modules and boundary branches were still untested. This change fills those gaps without spending effort on low-value defensive branches or type-only barrel files.

Impact

  • higher confidence in VBI internal helpers and builder edge cases
  • stronger regression protection for report/resource wiring and date filter predicate logic
  • repository README now reflects the latest VBI coverage badge

Validation

  • pnpm --filter @visactor/vbi run test
  • pnpm --filter @visactor/vbi run test:coverage
  • pnpm --filter @visactor/vbi run typecheck
  • pre-push hook: pnpm turbo typecheck

@youngwinds youngwinds marked this pull request as ready for review April 13, 2026 07:39
@youngwinds youngwinds merged commit 5da7acd into main Apr 13, 2026
3 checks passed
@youngwinds youngwinds deleted the codex/vbi-test-coverage branch April 13, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant