Skip to content

Fix/brush item highlight#1223

Merged
kkxxkk2019 merged 11 commits intodevelopfrom
fix/brush-item-highlight
Oct 17, 2023
Merged

Fix/brush item highlight#1223
kkxxkk2019 merged 11 commits intodevelopfrom
fix/brush-item-highlight

Conversation

@skie1997
Copy link
Copy Markdown
Contributor

@skie1997 skie1997 commented Oct 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

前置条件:
配置了图元select
配置了brush

触发bug的过程:
brush刷取时,交互起点在某个图元上,导致图元被select,此时移走选框,图元仍然保持select状态

原因:
使用vrender层的graphicItem.stateProxy会被反复执行,出现问题

解决方案:

  1. 使用vchart层的状态注册,而非vrender层
  2. init brush组件时,遍历所有系列,获取到每个系列需要被高亮的mark后使用setMarkStyle进行状态注册

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

Comment thread packages/vchart/src/chart/base-chart.ts Outdated
Comment thread packages/vchart/src/component/brush/brush.ts Outdated
@kkxxkk2019 kkxxkk2019 merged commit 7aac863 into develop Oct 17, 2023
@kkxxkk2019 kkxxkk2019 deleted the fix/brush-item-highlight branch October 17, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants