Skip to content

Fix/media query error #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 2 commits into from
Dec 19, 2024
Merged

Fix/media query error #3583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
708f4b6
fix: media query should not throw error when has empty axis, related …
xile611 Dec 19, 2024
68150cf
docs: update changlog of rush
xile611 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-media-query-error_2024-12-19-07-36.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: media query should not throw error when has empty axis, related to #3575\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
2 changes: 1 addition & 1 deletion packages/vchart/src/plugin/chart/media-query/util/filter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export const executeMediaQueryActionFilterType = <T extends Record<string, unkno
const infoList = array(chartSpecInfo.component?.[specKey] ?? []);
array(chartSpec[specKey] ?? []).forEach((componentSpec, i) => {
const specInfo = infoList[i];
if (componentTypes.includes(specInfo.type as ComponentTypeEnum)) {
if (specInfo && componentTypes.includes(specInfo.type as ComponentTypeEnum)) {
result.modelInfo.push({
...specInfo,
spec: componentSpec
Expand Down