Skip to content

Fix/undefined point dimension hover #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuefei1313 merged 2 commits into from
Jan 3, 2025
Merged

Fix/undefined point dimension hover #3620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
676c1fd
fix: undefined points shoulde not show when dimension hover, fix #3610
xile611 Dec 26, 2024
9011a52
docs: update changlog of rush
xile611 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/fix-undefined-point-dimension-hover_2024-12-26-08-03.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: undefined points shoulde not show when dimension hover, fix #3610\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
29 changes: 12 additions & 17 deletions packages/vchart/src/series/mixin/line-mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export interface LineLikeSeriesMixin extends ISeries {
_fieldZ?: string[];

_createMark: (markInfo: ISeriesMarkInfo, option?: ISeriesMarkInitOption, config?: ICompileMarkConfig) => IMark;
_getInvalidDefined: () => boolean;
_getInvalidDefined: (datum: Datum) => boolean;
_getInvalidConnectType: () => IInvalidType;

getLayoutRect: () => ILayoutRect;
Expand Down Expand Up @@ -316,26 +316,21 @@ export class LineLikeSeriesMixin {
'normal',
AttributeLevel.Series
);
if (this._invalidType !== 'zero') {
this.setMarkStyle(
symbolMark,
{
visible: this._getInvalidDefined.bind(this)
},
'normal',
AttributeLevel.Series
);
}

this.event.on(ChartEvent.viewDataStatisticsUpdate, { filter: param => param.model === this }, () => {
this.encodeDefined(symbolMark, 'visible');
});

this.setMarkStyle(
symbolMark,
{
x: this.dataToPositionX.bind(this),
y: this.dataToPositionY.bind(this),
x: (datum: Datum) => {
// 对于symbol而言，如果undefined 的元素还进行scale机会，Null/undefined 会被当成0，导致交互误显示的问题
return this._invalidType !== 'zero' && !this._getInvalidDefined(datum)
Comment thread
xuefei1313 marked this conversation as resolved.
? Number.NaN
: this.dataToPositionX(datum);
},
y: (datum: Datum) => {
return this._invalidType !== 'zero' && !this._getInvalidDefined(datum)
? Number.NaN
: this.dataToPositionY(datum);
},
z: this._fieldZ ? this.dataToPositionZ.bind(this) : null
},
'normal',
Expand Down