Skip to content

fix(vchart): fix heatmap scrollbar axis direction mismatch#4526

Merged
xuefei1313 merged 1 commit intodevelopfrom
009-fix-heatmap-scrollbar-axis-direction
Mar 24, 2026
Merged

fix(vchart): fix heatmap scrollbar axis direction mismatch#4526
xuefei1313 merged 1 commit intodevelopfrom
009-fix-heatmap-scrollbar-axis-direction

Conversation

@xuefei1313
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #4320

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

Fix the heatmap scrollbar and left-axis direction mismatch by aligning ScrollBar with DataZoom when converting scrollbar state percentages back into domain values.

Language/Version: TypeScript 4.9.x
Primary Dependencies: @visactor/vscale, @visactor/vutils, @visactor/vrender-components
Testing: Jest 26 unit tests under packages/vchart/__tests__
Target Platform: Browser and cross-platform cartesian chart runtime
Project Type: Monorepo charting library package (packages/vchart)
Constraints: Preserve existing dataZoom behavior; avoid changing axis range calculation; keep the fix scoped to scrollbar state-domain conversion

📝 Changelog

Language Changelog
🇺🇸 English Fix the heatmap right scrollbar so vertical scrolling stays in sync with the left band axis order.
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

…ch by aligning ScrollBar with DataZoom when converting scrollbar state percentages back into domain values
@xuefei1313 xuefei1313 force-pushed the 009-fix-heatmap-scrollbar-axis-direction branch from aafb83d to ac7b651 Compare March 23, 2026 09:13
@xuefei1313 xuefei1313 requested a review from skie1997 March 23, 2026 09:34
@xuefei1313 xuefei1313 merged commit 6f879b2 into develop Mar 24, 2026
8 of 10 checks passed
@xuefei1313 xuefei1313 deleted the 009-fix-heatmap-scrollbar-axis-direction branch March 24, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] scroll bar inverse in heatmap

2 participants