Skip to content

fix(vchart): fix an issue where mark states were not properly cleared when updateSpec was called, causing incorrect state persistence#4529

Merged
xuefei1313 merged 1 commit intodevelopfrom
009-fix-issue-of-mark-state-when-updateSpec
Mar 25, 2026
Merged

fix(vchart): fix an issue where mark states were not properly cleared when updateSpec was called, causing incorrect state persistence#4529
xuefei1313 merged 1 commit intodevelopfrom
009-fix-issue-of-mark-state-when-updateSpec

Conversation

@xuefei1313
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

Fix an issue where mark states were not properly cleared when updateSpec was called, causing incorrect state persistence.

The updateSpec process re-initializes marks but previous state information was lingering.
Changes include:

  • Added clearAllStateInfo method to IMarkStateManager interface and implementation.
  • Added clearBeforeReInit method to IMarkRaw interface and implementation.
  • Invoked clearBeforeReInit in BaseMark during re-initialization.
  • Updated BaseSeries to handle state cleanup during spec updates.

📝 Changelog

Language Changelog
🇺🇸 English fix lingering mark states after updateSpec reinit
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

… when updateSpec was called, causing incorrect state persistence
@xuefei1313 xuefei1313 merged commit 03ab1d3 into develop Mar 25, 2026
9 of 11 checks passed
@xuefei1313 xuefei1313 deleted the 009-fix-issue-of-mark-state-when-updateSpec branch March 25, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants