Fix/sankey tooltip when zero#4557
Merged
xuefei1313 merged 2 commits intodev/1.13.0from Apr 13, 2026
Merged
Conversation
The Sankey tooltip helper treated source=0 as falsy, so link tooltips for the first indexed source skipped the expected "A => B" title. Add a regression test for the zero-index case and record the package changefile. Constraint: Sankey links can reference nodes by numeric index including 0 Rejected: Coerce source/target to strings before checks | still obscures the real bug Confidence: high Scope-risk: narrow Reversibility: clean Directive: Use nil checks for Sankey source/target presence instead of truthiness checks Tested: npm test -- --runInBand __tests__/unit/series/sankey.test.ts; npm run compile Not-tested: Browser hover interaction in the runtime playground
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough