Merged
Conversation
The radar chart transformer copied a visible:false default into the series default spec before series themes were merged. That caused chart-level radar themes to lose area.visible:true whenever the chart spec provided area config without its own visible flag. Use the current radar area theme visibility as the series default and add a regression test for the style-only chart-area case. Constraint: Chart transformers downcast chart-level radar area config before series theme merge Rejected: Remove the radar area default entirely | changes no-theme area-style behavior Confidence: medium Scope-risk: narrow Reversibility: clean Directive: Keep radar chart defaults aligned with later series-theme precedence Tested: npm test -- --runInBand __tests__/unit/theme/radar.test.ts Tested: npm test -- --runInBand __tests__/unit/theme/line.test.ts __tests__/unit/theme/radar.test.ts Tested: npm run compile Not-tested: Full package eslint clean run; repo has pre-existing lint errors and warnings Not-tested: Browser runtime smoke for radar theme switching
Common-chart series interactions were merged by region and trigger type only. That collapsed distinct element-active configs into one trigger and let series with different trigger events interfere with each other. Group triggers by full config within a region. Add regression coverage for mixed trigger setups. Guard element-active reset when no stated graphics have been recorded yet. Constraint: Common chart initializes series interactions centrally in BaseChart Rejected: Keep type-only grouping Rejected: Special-case element-active | leaves other mixed-trigger cases broken Confidence: high Scope-risk: narrow Reversibility: clean Directive: Merge interaction triggers only when their effective configs match Directive: Do not merge by trigger type alone Tested: npm test -- --runInBand __tests__/unit/core/vchart-event.test.ts Tested: npm run compile Not-tested: Full package lint sweep Not-tested: Repository has pre-existing lint noise outside this change Related: issue1 common-chart element-active isolation
Contributor
Author
SummaryThis PR fixes a couple of related theme/interaction edge cases:
Overall the direction looks correct and the added tests are helpful. Notes on the implementation
Suggestions
Verification
|
skie1997
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #4550 #4562
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough