Skip to content

Fix/issue 566 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkxxkk2019 merged 2 commits into from
Aug 21, 2023
Merged

Fix/issue 566 #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e921f5a
fix(vchart): fix the issue of the chart's size is not correctly when …
kkxxkk2019 Aug 21, 2023
d837435
chore: update rush change
kkxxkk2019 Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@visactor/vchart/fix-issue-566_2023-08-21-10-04.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vchart",
"comment": "fix: fix the issue of the chart's size is not correctly when updateSpec in lark block env, closed #566",
"type": "none"
}
],
"packageName": "@visactor/vchart"
}
18 changes: 9 additions & 9 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion packages/vchart/src/chart/base-chart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ import {
isTrueBrowser,
isString,
config,
convertBackgroundSpec
convertBackgroundSpec,
isMiniAppLikeMode
} from '../util';
import { Stack } from './stack';
import { BaseModel } from '../model/base-model';
Expand Down Expand Up @@ -703,6 +704,10 @@ export class BaseChart extends CompilableBase implements IChart {
);
width = containerWidth;
height = containerHeight;
} else if (isMiniAppLikeMode(this._option.mode) && (this._option.modeParams as any)?.domref) {
const domRef = (this._option.modeParams as any).domref;
width = domRef.width;
height = domRef.height;
}

width = userWidth ?? width;
Expand Down