Skip to content

Fix: duplicated label #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neuqzxy merged 2 commits into from
Jan 10, 2025
Merged

Fix: duplicated label #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
871cb46
fix: fix duplicate label issue after custom filtering with label data…
xiaoluoHe Jan 7, 2025
67f3537
docs: add changelog
xiaoluoHe Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@visactor/vrender-components/fix-duplicated-label-id_2025-01-07-06-46.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vrender-components",
"comment": "fix: fix duplicate label issue after custom filtering with label dataFilter",
"type": "none"
}
],
"packageName": "@visactor/vrender-components"
}
6 changes: 6 additions & 0 deletions packages/vrender-components/src/label/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,12 @@ export class LabelBase<T extends BaseLabelAttrs> extends AbstractComponent<T> {
data = dataFilter(data);
}

if (data && data.length) {
// 数据保护，防止重复 id 造成不可预知的问题
const seenIds = new Set();
data = data.filter(d => !seenIds.has(d.id) && seenIds.add(d.id));
}

let labels: (IText | IRichText)[] = this._initText(data);

if (isFunction(customLayoutFunc)) {
Expand Down