fix: replace removed getAllElements API with forEachChildren in WaveScatter#301
Merged
fix: replace removed getAllElements API with forEachChildren in WaveScatter#301
Conversation
…catter mark.getProduct() now returns IGroup (VRender) which does not have the old VGrammar getAllElements() method. Use forEachChildren to iterate over the group's child graphics instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a runtime crash in the WaveScatter character’s visibility (“appear”) action by updating child-graphic collection logic to match the current VRender IGroup API returned by mark.getProduct().
Changes:
- Replaced usage of the removed
getAllElements()API withforEachChildren()to collect graphics from the mark product group.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
xuefei1313
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WaveScatter character crashes on
appearaction with:Root Cause
mark.getProduct()now returns VRenderIGroup, which does not have the old VGrammargetAllElements()method.Fix
Replace
product.getAllElements().map(item => item.getGraphicItem())withproduct.forEachChildren()to collect child graphics directly from the group — consistent with how the baseVChartVisibilityActionProcessoralready iterates over group children.