Fix/5020 scroll to row dynamic row height#5052
Merged
Conversation
…n with dynamic row heights getRowsHeight() has a fast path that multiplies defaultRowHeight by the row count for body rows when heightMode is 'standard', completely ignoring rowHeightsMap. This means rows with computed heights (e.g. from autoWrapText) are not reflected in the scroll position calculation, causing scrollToRow to land at the wrong position. Fix: use rowHeightsMap.getSumInRange directly in scrollToCell so that actual computed row heights are used for both the target position and the max-scroll cap. For unrendered rows, getSumInRange already falls back to getRowHeight (defaultRowHeight), so behavior is unchanged when no rows have been dynamically sized. Closes #5020
…c-row-height fix(table): use rowHeightsMap directly in scrollToCell to fix position with dynamic row heights
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run bugserver cases for #5051
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough