Skip to content

fix: clear resize column/row indicator line when setRecords or updateOption is called #4120#5067

Merged
fangsmile merged 2 commits intoVisActor:fix/resize-col-line-stuck-4120from
Erica-cod:fix/resize-col-line-stuck-4120
Mar 25, 2026
Merged

fix: clear resize column/row indicator line when setRecords or updateOption is called #4120#5067
fangsmile merged 2 commits intoVisActor:fix/resize-col-line-stuck-4120from
Erica-cod:fix/resize-col-line-stuck-4120

Conversation

@Erica-cod
Copy link

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Chore
  • Release
  • Other (about what?)

🔗 Related issue link

close #4120

💡 Background and solution

When a user is dragging to resize a column width (or row height), if external code calls setRecords() or updateOption() at the same time, the resize indicator line gets stuck on the table and never disappears.

Root cause: In _updateOptionSetState(), the resize state (columnResize.resizing, rowResize.resizing) is reset to false and interactionState is set back to default, but hideResizeCol() / hideResizeRow() is never called to hide the visual indicator line. When the user later releases the mouse, the pointerup handler checks isResizeCol() && grabing — both are already false, so endResizeCol() is skipped and the line remains visible forever.

Solution: Added checks at the beginning of _updateOptionSetState() and setRecords() (in ListTable, PivotTable, and PivotChart) to detect if a resize operation is in progress, and if so, hide the indicator line and reset the resize state before proceeding.

📝 Changelog

Language Changelog
🇺🇸 English fix: clear resize column/row indicator line when setRecords or updateOption is called during resizing
🇨🇳 Chinese 修复:在列宽/行高调整过程中调用 setRecords 或 updateOption 时,调整指示线残留在表格上无法消失的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@fangsmile fangsmile changed the base branch from develop to fix/resize-col-line-stuck-4120 March 25, 2026 01:19
@fangsmile fangsmile merged commit 03e6ef2 into VisActor:fix/resize-col-line-stuck-4120 Mar 25, 2026
2 checks passed
@fangsmile fangsmile mentioned this pull request Mar 25, 2026
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

如果列宽正在调整中,没有结束,此时records更新,会导致列宽调整的线卡在表格上消失不了,如何解决

2 participants