fix: clear resize column/row indicator line when setRecords or updateOption is called #4120#5067
Merged
fangsmile merged 2 commits intoVisActor:fix/resize-col-line-stuck-4120from Mar 25, 2026
Conversation
…Option is called VisActor#4120 Made-with: Cursor
Made-with: Cursor
03e6ef2
into
VisActor:fix/resize-col-line-stuck-4120
2 checks passed
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #4120
💡 Background and solution
When a user is dragging to resize a column width (or row height), if external code calls
setRecords()orupdateOption()at the same time, the resize indicator line gets stuck on the table and never disappears.Root cause: In
_updateOptionSetState(), the resize state (columnResize.resizing,rowResize.resizing) is reset tofalseandinteractionStateis set back todefault, buthideResizeCol()/hideResizeRow()is never called to hide the visual indicator line. When the user later releases the mouse, thepointeruphandler checksisResizeCol() && grabing— both are alreadyfalse, soendResizeCol()is skipped and the line remains visible forever.Solution: Added checks at the beginning of
_updateOptionSetState()andsetRecords()(inListTable,PivotTable, andPivotChart) to detect if a resize operation is in progress, and if so, hide the indicator line and reset the resize state before proceeding.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough