Skip to content

5102 bug aggregation float #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fangsmile wants to merge 3 commits into
base: develop
Choose a base branch
from
+118 −69
Open

5102 bug aggregation float #5103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b1b0ab
fix: aggregation precisionAdd precisionSub
fangsmile Apr 10, 2026
e3816ab
docs: update changlog of rush
fangsmile Apr 10, 2026
b23408c
fix: aggregation error
fangsmile Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vtable/5102-bug-aggregation-float_2026-04-10-01-47.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: aggregation precisionAdd precisionSub\n\n",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "892739385@qq.com"
}
17 changes: 17 additions & 0 deletions packages/vtable/__tests__/dataset/aggregation-float.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { SumAggregator } from '../../src/ts-types/dataset/aggregation';

describe('SumAggregator floating point precision', () => {
it('should sum 0.1 and 0.2 exactly to 0.3', () => {
const aggregator = new SumAggregator({ key: 'test', field: 'value', isRecord: false });
aggregator.push({ value: 0.1 });
aggregator.push({ value: 0.2 });
expect(aggregator.value()).toBe(0.3);
});

it('should subtract correctly', () => {
const aggregator = new SumAggregator({ key: 'test', field: 'value', isRecord: false });
aggregator.push({ value: 0.3 });
aggregator.deleteRecord({ value: 0.1 });
expect(aggregator.value()).toBe(0.2);
});
});
4 changes: 2 additions & 2 deletions packages/vtable/__tests__/pivotChart.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9487,7 +9487,7 @@ describe('pivotChart init test', () => {
},
二级: {
max: 81585.58783792704,
min: -15135.001037597656,
min: -15135.001037597654,
positiveMax: 81585.58783792704,
negativeMin: -19659.724044799805
},
Expand Down Expand Up @@ -9598,7 +9598,7 @@ describe('pivotChart init test', () => {
},
'230713150305011': {
一级: {
max: 40780.32046222687,
max: 40780.32046222686,
min: -22801.40795326233,
positiveMax: 44028.34812831879,
negativeMin: -22801.40795326233
Expand Down
155 changes: 88 additions & 67 deletions packages/vtable/src/ts-types/dataset/aggregation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { isValid } from '@visactor/vutils';
import { isValid, precisionAdd, precisionSub } from '@visactor/vutils';
import type { SortOrder } from '..';
import { AggregationType, SortType } from '..';
import type { BaseTableAPI } from '../base-table';
Expand Down Expand Up @@ -409,22 +409,22 @@ export class SumAggregator extends Aggregator {
if (record.isAggregator && this.children) {
this.children.push(record);
const value = record.value();
this.sum += value ?? 0;
this.sum = precisionAdd(this.sum, value ?? 0);
if (this.needSplitPositiveAndNegativeForSum) {
if (value > 0) {
this.positiveSum += value;
this.positiveSum = precisionAdd(this.positiveSum, value);
} else if (value < 0) {
this.nagetiveSum += value;
this.nagetiveSum = precisionAdd(this.nagetiveSum, value);
}
}
} else if (this.field && !isNaN(parseFloat(record[this.field]))) {
const value = parseFloat(record[this.field]);
this.sum += value;
this.sum = precisionAdd(this.sum, value);
if (this.needSplitPositiveAndNegativeForSum) {
if (value > 0) {
this.positiveSum += value;
this.positiveSum = precisionAdd(this.positiveSum, value);
} else if (value < 0) {
this.nagetiveSum += value;
this.nagetiveSum = precisionAdd(this.nagetiveSum, value);
}
}
}
Expand All @@ -434,27 +434,33 @@ export class SumAggregator extends Aggregator {
deleteRecord(record: any) {
if (record) {
if (this.isRecord && this.records) {
this.records = this.records.filter(item => item !== record);
const index = this.records.indexOf(record);
if (index !== -1) {
this.records.splice(index, 1);
}
}
if (record.isAggregator && this.children) {
this.children = this.children.filter(item => item !== record);
const index = this.children.indexOf(record);
if (index !== -1) {
this.children.splice(index, 1);
}
const value = record.value();
this.sum -= value ?? 0;
this.sum = precisionSub(this.sum, value ?? 0);
if (this.needSplitPositiveAndNegativeForSum) {
if (value > 0) {
this.positiveSum -= value;
this.positiveSum = precisionSub(this.positiveSum, value);
} else if (value < 0) {
this.nagetiveSum -= value;
this.nagetiveSum = precisionSub(this.nagetiveSum, value);
}
}
} else if (this.field && !isNaN(parseFloat(record[this.field]))) {
const value = parseFloat(record[this.field]);
this.sum -= value;
this.sum = precisionSub(this.sum, value);
if (this.needSplitPositiveAndNegativeForSum) {
if (value > 0) {
this.positiveSum -= value;
this.positiveSum = precisionSub(this.positiveSum, value);
} else if (value < 0) {
this.nagetiveSum -= value;
this.nagetiveSum = precisionSub(this.nagetiveSum, value);
}
}
}
Expand All @@ -464,53 +470,56 @@ export class SumAggregator extends Aggregator {
updateRecord(oldRecord: any, newRecord: any): void {
if (oldRecord && newRecord) {
if (this.isRecord && this.records) {
this.records = this.records.map(item => {
if (item === oldRecord) {
return newRecord;
}
return item;
});
const index = this.records.indexOf(oldRecord);
if (index !== -1) {
this.records[index] = newRecord;
}
}
if (oldRecord.isAggregator && this.children) {
const oldValue = oldRecord.value();
this.children = this.children.filter(item => item !== oldRecord);
const index = this.children.indexOf(oldRecord);
if (index !== -1) {
this.children[index] = newRecord;
}
const newValue = newRecord.value();
this.children.push(newRecord);
this.sum += newValue - oldValue;
this.sum = precisionAdd(this.sum, precisionSub(newValue, oldValue));
if (this.needSplitPositiveAndNegativeForSum) {
if (oldValue > 0) {
this.positiveSum -= oldValue;
this.positiveSum = precisionSub(this.positiveSum, oldValue);
} else if (oldValue < 0) {
this.nagetiveSum -= oldValue;
this.nagetiveSum = precisionSub(this.nagetiveSum, oldValue);
}
if (newValue > 0) {
this.positiveSum += newValue;
this.positiveSum = precisionAdd(this.positiveSum, newValue);
} else if (newValue < 0) {
this.nagetiveSum += newValue;
this.nagetiveSum = precisionAdd(this.nagetiveSum, newValue);
}
}
} else if (this.field && !isNaN(parseFloat(oldRecord[this.field]))) {
const oldValue = parseFloat(oldRecord[this.field]);
const newValue = parseFloat(newRecord[this.field]);
this.sum += newValue - oldValue;
this.sum = precisionAdd(this.sum, precisionSub(newValue, oldValue));
if (this.needSplitPositiveAndNegativeForSum) {
if (oldValue > 0) {
this.positiveSum -= oldValue;
this.positiveSum = precisionSub(this.positiveSum, oldValue);
} else if (oldValue < 0) {
this.nagetiveSum -= oldValue;
this.nagetiveSum = precisionSub(this.nagetiveSum, oldValue);
}
if (newValue > 0) {
this.positiveSum += newValue;
this.positiveSum = precisionAdd(this.positiveSum, newValue);
} else if (newValue < 0) {
this.nagetiveSum += newValue;
this.nagetiveSum = precisionAdd(this.nagetiveSum, newValue);
}
}
}
this.clearCacheValue();
}
}
value() {
return this.changedValue ?? (this.records?.length >= 1 ? this.sum : undefined);
return (
this.changedValue ??
(this.records && this.records.length >= 1 ? this.sum : this.isRecord === false ? this.sum : undefined)
);
}
positiveValue() {
return this.positiveSum;
Expand All @@ -531,12 +540,12 @@ export class SumAggregator extends Aggregator {
const child = this.children[i];
if (child.isAggregator) {
const value = child.value();
this.sum += value ?? 0;
this.sum = precisionAdd(this.sum, value ?? 0);
if (this.needSplitPositiveAndNegativeForSum) {
if (value > 0) {
this.positiveSum += value;
this.positiveSum = precisionAdd(this.positiveSum, value);
} else if (value < 0) {
this.nagetiveSum += value;
this.nagetiveSum = precisionAdd(this.nagetiveSum, value);
}
}
}
Expand All @@ -546,22 +555,22 @@ export class SumAggregator extends Aggregator {
const record = this.records[i];
if (record.isAggregator) {
const value = record.value();
this.sum += value ?? 0;
this.sum = precisionAdd(this.sum, value ?? 0);
if (this.needSplitPositiveAndNegativeForSum) {
if (value > 0) {
this.positiveSum += value;
this.positiveSum = precisionAdd(this.positiveSum, value);
} else if (value < 0) {
this.nagetiveSum += value;
this.nagetiveSum = precisionAdd(this.nagetiveSum, value);
}
}
} else if (this.field && !isNaN(parseFloat(record[this.field]))) {
const value = parseFloat(record[this.field]);
this.sum += value;
this.sum = precisionAdd(this.sum, value);
if (this.needSplitPositiveAndNegativeForSum) {
if (value > 0) {
this.positiveSum += value;
this.positiveSum = precisionAdd(this.positiveSum, value);
} else if (value < 0) {
this.nagetiveSum += value;
this.nagetiveSum = precisionAdd(this.nagetiveSum, value);
}
}
}
Expand Down Expand Up @@ -687,10 +696,10 @@ export class AvgAggregator extends Aggregator {
if (this.children) {
this.children.push(record);
}
this.sum += record.sum;
this.sum = precisionAdd(this.sum, record.sum);
this.count += record.count;
} else if (this.field && !isNaN(parseFloat(record[this.field]))) {
this.sum += parseFloat(record[this.field]);
this.sum = precisionAdd(this.sum, parseFloat(record[this.field]));
this.count++;
}
}
Expand All @@ -699,16 +708,22 @@ export class AvgAggregator extends Aggregator {
deleteRecord(record: any) {
if (record) {
if (this.isRecord && this.records) {
this.records = this.records.filter(item => item !== record);
const index = this.records.indexOf(record);
if (index !== -1) {
this.records.splice(index, 1);
}
}
if (record.isAggregator && record.type === AggregationType.AVG) {
if (this.children) {
this.children = this.children.filter(item => item !== record);
const index = this.children.indexOf(record);
if (index !== -1) {
this.children.splice(index, 1);
}
}
this.sum -= record.sum;
this.sum = precisionSub(this.sum, record.sum);
this.count -= record.count;
} else if (this.field && !isNaN(parseFloat(record[this.field]))) {
this.sum -= parseFloat(record[this.field]);
this.sum = precisionSub(this.sum, parseFloat(record[this.field]));
this.count--;
}
}
Expand All @@ -717,33 +732,39 @@ export class AvgAggregator extends Aggregator {
updateRecord(oldRecord: any, newRecord: any): void {
if (oldRecord && newRecord) {
if (this.isRecord && this.records) {
this.records = this.records.map(item => {
if (item === oldRecord) {
return newRecord;
}
return item;
});
const index = this.records.indexOf(oldRecord);
if (index !== -1) {
this.records[index] = newRecord;
}
}
if (oldRecord.isAggregator && oldRecord.type === AggregationType.AVG) {
if (this.children && newRecord.isAggregator) {
this.children = this.children.map(item => {
if (item === oldRecord) {
return newRecord;
}
return item;
});
const index = this.children.indexOf(oldRecord);
if (index !== -1) {
this.children[index] = newRecord;
}
}
this.sum += newRecord.sum - oldRecord.sum;
this.sum = precisionAdd(this.sum, precisionSub(newRecord.sum, oldRecord.sum));
this.count += newRecord.count - oldRecord.count;
} else if (this.field && !isNaN(parseFloat(oldRecord[this.field]))) {
this.sum += parseFloat(newRecord[this.field]) - parseFloat(oldRecord[this.field]);
this.sum = precisionAdd(
this.sum,
precisionSub(parseFloat(newRecord[this.field]), parseFloat(oldRecord[this.field]))
);
// this.count++;
}
this.clearCacheValue();
}
}
value() {
return this.changedValue ?? (this.records?.length >= 1 ? this.sum / this.count : undefined);
return (
this.changedValue ??
(this.records && this.records.length >= 1
? this.sum / this.count
: this.isRecord === false && this.count > 0
? this.sum / this.count
: undefined)
);
}
reset() {
this.changedValue = undefined;
Expand All @@ -761,18 +782,18 @@ export class AvgAggregator extends Aggregator {
const child = this.children[i];
if (child.isAggregator && child.type === AggregationType.AVG) {
const childValue = child.value();
this.sum += childValue * (child as AvgAggregator).count;
this.sum = precisionAdd(this.sum, childValue * (child as AvgAggregator).count);
this.count += (child as AvgAggregator).count;
}
}
} else if (this.records) {
for (let i = 0; i < this.records.length; i++) {
const record = this.records[i];
if (record.isAggregator && record.type === AggregationType.AVG) {
this.sum += record.sum;
this.sum = precisionAdd(this.sum, record.sum);
this.count += record.count;
} else if (this.field && !isNaN(parseFloat(record[this.field]))) {
this.sum += parseFloat(record[this.field]);
this.sum = precisionAdd(this.sum, parseFloat(record[this.field]));
this.count++;
}
}
Expand Down
Loading