Skip to content

Conversation

@TheFreeman193
Copy link

At present KAD doesn't use an RSA KeyPairGenerator when in RSA mode and the ECDSA key type is hardcoded.

This change removes the key type specialisation from the constructors of the AttestationRepository and AndroidKeyStore classes and moves key type handling into the generateKeyPair() method, which already has the key type byte passed as a parameter.

AndroidKeyStore now initialises both ECDSA and RSA KeyPairGenerator instances at construction and selects the correct one in generateKeyPair() using the keyStoreKeyType parameter.

@VisionR1 VisionR1 merged commit 34b8e94 into VisionR1:master Oct 28, 2025
3 checks passed
@VisionR1
Copy link
Owner

Thanks.

I appreciate it, as always. 🙏🏻

So, except for the action build, i merged your PR, all seems to working.

@TheFreeman193 TheFreeman193 deleted the rsa-mode-fix branch October 28, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants