Skip to content

Conversation

@thibo73800
Copy link
Contributor

General description of your pull request with the list of new features and/or bugs.

  • New feature 1 :
    When manipulating aug tensor, _saved_names can accumulate None values which could prevent proper concatenation. Note that this might not be an issue once we have a good merging policy of different properties within aug tensors.

This pull request includes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@TahaAzzim TahaAzzim self-requested a review November 17, 2022 14:12
@thibo73800 thibo73800 linked an issue Nov 17, 2022 that may be closed by this pull request
@TahaAzzim TahaAzzim merged commit f16022e into alobugdays Nov 17, 2022
@thibo73800 thibo73800 deleted the 267-saved-names-none branch November 17, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_saved_names can accumulate None within tuple

3 participants