Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- name: Install npm dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- name: Install dependencies
run: npm ci
Expand Down
3 changes: 1 addition & 2 deletions lib/playwright.interfaces.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { IgnoreArea } from "@visual-regression-tracker/sdk-js";
import { ElementHandle } from "playwright-core";
import { Page } from "@playwright/test";
import { Page, ElementHandle } from "@playwright/test";

export interface Agent {
os?: string;
Expand Down
29 changes: 12 additions & 17 deletions lib/playwrightVisualRegressionTracker.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ import {
Config,
VisualRegressionTracker,
} from "@visual-regression-tracker/sdk-js";
import { Browser, BrowserContext, Page, chromium } from "@playwright/test";
import { Browser, BrowserContext, ElementHandle, Page, chromium } from "@playwright/test";
import {
PlaywrightVisualRegressionTracker,
PageTrackOptions,
ElementHandleTrackOptions,
} from "./index";
import { mocked } from "ts-jest/utils";
import { MaybeMocked } from "ts-jest/dist/utils/testing";
import { mocked, type Mocked } from "jest-mock";

jest.mock("@visual-regression-tracker/sdk-js");

Expand Down Expand Up @@ -66,13 +65,13 @@ describe("playwright", () => {
});

describe("track", () => {
let pageMocked: MaybeMocked<Page>;
let pageMocked: Mocked<Page>;
const screenshot: Buffer = Buffer.from("image mocked");

beforeEach(() => {
playwrightVrt["vrt"]["isStarted"] = jest.fn().mockReturnValueOnce(true);
pageMocked = mocked(page);
pageMocked.screenshot = jest.fn().mockResolvedValueOnce(screenshot);
pageMocked.screenshot = jest.fn().mockResolvedValueOnce(screenshot) as any;
});

describe("trackPage", () => {
Expand Down Expand Up @@ -128,7 +127,7 @@ describe("playwright", () => {

it("track default fields", async () => {
const imageName = "test name";
pageMocked.viewportSize = jest.fn().mockReturnValueOnce(null);
pageMocked.viewportSize = jest.fn().mockReturnValueOnce(null) as any;

await playwrightVrt.trackPage(page, imageName);

Expand Down Expand Up @@ -173,12 +172,10 @@ describe("playwright", () => {
},
comment: "Test comment",
};
pageMocked.$ = jest.fn().mockResolvedValueOnce({});
pageMocked.$ = jest.fn().mockResolvedValueOnce({} as ElementHandle<HTMLElement>) as any;
const elementHandle = await page.$("#test");
const elementHandleMocked = mocked(elementHandle);
elementHandleMocked!.screenshot = jest
.fn()
.mockResolvedValueOnce(screenshot);
const elementHandleMocked = mocked(elementHandle as object as ElementHandle<HTMLElement>);
elementHandleMocked!.screenshot = jest.fn().mockResolvedValueOnce(screenshot) as any;

await playwrightVrt.trackElementHandle(
elementHandle,
Expand Down Expand Up @@ -207,12 +204,10 @@ describe("playwright", () => {

it("track default fields", async () => {
const imageName = "test name";
pageMocked.$ = jest.fn().mockResolvedValueOnce({});
pageMocked.$ = jest.fn().mockResolvedValueOnce({} as ElementHandle<HTMLElement>) as any;
const elementHandle = await page.$("#test");
const elementHandleMocked = mocked(elementHandle);
elementHandleMocked!.screenshot = jest
.fn()
.mockResolvedValueOnce(screenshot);
const elementHandleMocked = mocked(elementHandle as object as ElementHandle<HTMLElement>);
elementHandleMocked!.screenshot = jest.fn().mockResolvedValueOnce(screenshot) as any;

await playwrightVrt.trackElementHandle(elementHandle, imageName);

Expand All @@ -234,7 +229,7 @@ describe("playwright", () => {

it("should throw if no elementHandle", async () => {
const imageName = "test name";
pageMocked.$ = jest.fn().mockResolvedValueOnce(null);
pageMocked.$ = jest.fn().mockResolvedValueOnce(null) as any;
const elementHandle = await page.$("#test");

await expect(
Expand Down
Loading