-
Notifications
You must be signed in to change notification settings - Fork 12
Issue 135 : Added ability to limit number of builds to keep (just like Jenkins) #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pashidlos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suratdas thanks for contribution!
unfortunately this is not aligned with the idea of self contained entities
having one object implicitly related to multiple objects makes complicated it's management and could potentially lead to broken relations
I would sacrifice this additional memory consumption to simplicity in logic
|
The logic has been modified to limit how many builds we want to keep just like Jenkins does without having us manually delete old builds. This is similar to issue Visual-Regression-Tracker/Visual-Regression-Tracker#146 |
8cc9222 to
f986679
Compare
pashidlos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add unit and/or e2e test for this feature?
pashidlos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@suratdas thanks for contribution! |
Addresses Visual-Regression-Tracker/Visual-Regression-Tracker#135
This pull request does following