-
Notifications
You must be signed in to change notification settings - Fork 12
Feature: add ldap support #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
409cb8f to
ceca1f2
Compare
|
Hi, now it's working as expected for me. |
|
@nitschSB thanks for contirubtion! |
|
I added some local test setup. have a look at the README.md I'm not familiar with the frameworks you use. I got this done with the help of copilot and try&error. I think some automated tests would be nice, but my attempts were not successful - sorry for the bad test coverage. |
|
Hi @pashidlos , do you have any questions about this? Is there anything you want me to do before merging? |
356fce0 to
9e67543
Compare
4c4ab3d to
66b3037
Compare
8d11cd5 to
66c3809
Compare
66c3809 to
ad1cbb2
Compare
|
Hi @pashidlos , I did my best to adopt the factory pattern, like you did for storage. I also added a e2e with ldap test to the Looking forward to see a merge soon ;) Cheers |
I added an ldap user service that connects to the an ldap server.
For every ldap user that logs in the first time, a vrt user is created with editor role.
Visual-Regression-Tracker/#324