Skip to content

Conversation

@suratdas
Copy link
Collaborator

@suratdas suratdas commented Jun 18, 2021

Addresses issue Visual-Regression-Tracker/Visual-Regression-Tracker#276
Changes included:

  1. Clear icon will clear ignore area of the selected images.
  2. Apply ignore area icon will be enabled only one selection and then on confirming apply, it will apply the selected ignore area to all images in the build.
  3. For small number of selection, both the "wait for processing" snackbar and success snackbar come almost at the same time which may confuse users. Replace this with a progress bar under the action icons.

I will raise a matching backend pull request if this is approved in principal. Here are some screenshots for reference.

progressBar

newIconsWithTooltip

clearConfirmation

@suratdas suratdas requested a review from pashidlos June 18, 2021 21:27
Copy link
Member

@pashidlos pashidlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like part with clear ignore areas
would you like to add the same button in test run details modal to clear ignore areas for specific test run?

the part regarding copying is not quite clear for me
not sure that this would be useful if it's not possible to select target test runs

@suratdas
Copy link
Collaborator Author

Removed apply logic now. Will implement later from details view.

@suratdas suratdas changed the title Issue #276: Enable to bulk clear/apply ignore area for test runs Issue #276: Enable to bulk clear ignore area for test runs list and details view. Jun 20, 2021
@suratdas suratdas requested a review from pashidlos June 20, 2021 02:40
Copy link
Member

@pashidlos pashidlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pashidlos pashidlos merged commit 6a5e949 into master Jun 21, 2021
@pashidlos pashidlos deleted the bulk-ignore-area branch June 21, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants