Skip to content

Conversation

@suratdas
Copy link
Collaborator

@suratdas suratdas commented Jul 30, 2021

@suratdas suratdas requested a review from pashidlos July 30, 2021 14:39
Copy link
Member

@pashidlos pashidlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that could be really useful for new users
awesome idea!

Copy link
Member

@pashidlos pashidlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you take a look on refactoring propose for HelpContext?
#226

I try to make it this way based on this
https://kentcdodds.com/blog/how-to-use-react-context-effectively

@suratdas suratdas requested a review from pashidlos August 10, 2021 06:55
Copy link
Member

@pashidlos pashidlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pashidlos pashidlos merged commit 27c6d1e into master Aug 11, 2021
@pashidlos pashidlos deleted the frontend-help branch August 11, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants