Feature/help texts #248
Merged
Feature/help texts #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pashidlos
requested changes
Nov 17, 2021
src/components/Tooltip.tsx
Outdated
| import { Tooltip as MuiTooltip } from "@material-ui/core"; | ||
| import React from "react"; | ||
|
|
||
| export class Tooltip extends React.Component<any, any> { |
Member
There was a problem hiding this comment.
make it as functional component
also avoid using any
Contributor
Author
There was a problem hiding this comment.
Ok, I tried to make it a functional component, seems to work.
README.md
Outdated
|
|
||
| - clone repo | ||
| - `npm i` | ||
| - `npm run build` |
Member
There was a problem hiding this comment.
not sure that it's needed to run before local start
why would you need to run it?
Contributor
Author
There was a problem hiding this comment.
Right, works without. I removed it.
Roemer
force-pushed
the
feature/help-texts
branch
from
4b3b630 to
ec74879
Compare
Roemer
force-pushed
the
feature/help-texts
branch
from
ec74879 to
08ef4bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check especially the new help texts if they contain the correct information.
Replaces PR #247