-
Notifications
You must be signed in to change notification settings - Fork 7
Moving to Vite from Create-React-App and configuring ESLint and Jest #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Currently build creates the following bundles: I started to split them, as can be seen with |
|
Separated Material UI (most of it): I will leave the build like this, unless some comments arrive. The used libraries could be evaluated once the UI redesign begins... |
… the currently used major
…alse positive issues
e1e062b to
87bfefb
Compare
pashidlos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
increment node version in Dockerfile, please
| outDir: 'build', | ||
|
|
||
| // https://rollupjs.org/configuration-options/ | ||
| rollupOptions: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is an issue after running in docker that is solved with commenting that part
do you know how to fix it?
material-dcbda5c5.js:1 Uncaught ReferenceError: Cannot access 'Ve' before initialization
at material-dcbda5c5.js:1:3416
run docker-compose up --build and open localhost:8080
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was indeed due to the library chunks, which are now again all in one.
However there are some issues now with react elements after login...
|
@pashidlos about the |
not sure if it's still valid now |
pashidlos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@paazmaya create release after it's merged to build prod image |
|
@pashidlos now Codacy is stuck, previously it was not finding dependencies... What can we do? |
|
@paazmaya I guess it failed due to huge commit number |
Work in progress...
Moving from Create-React-App to Vite, but needed to configure Jest and ESLint separately.
Tests are currently revealing a lot of problems, but it might be due to version mismatches..
Work continues, but here for visibility and discussion.