Use Node.js CLI to update env vars during start time #334
Conversation
|
this should solve security issue https://github.com/Visual-Regression-Tracker/frontend/pull/197/files |
| FROM nginx:1.25-alpine3.18-slim | ||
|
|
||
| # Install Node.js LTS version needed for env variable generation | ||
| RUN apk add --update nodejs |
There was a problem hiding this comment.
I guess this part is the reason for image size increase
https://github.com/Visual-Regression-Tracker/frontend/releases/tag/v5.0.0-rc4
https://hub.docker.com/repository/registry-1.docker.io/visualregressiontracker/ui/tags?page=1&ordering=last_updated
There was a problem hiding this comment.
Yes, it is the smaller possible image that has nodejs
|
SonarCloud Quality Gate failed.
|
| COPY .env . | ||
|
|
||
| # Start Nginx server with override ENV variables script | ||
| CMD ["/bin/sh", "-c", "node /usr/share/nginx/html/generate-env-browser.mjs && nginx -g \"daemon off;\""] |
There was a problem hiding this comment.
could you try with docker-compose if it works?
I get error using those versions
VRT_UI_VERSION=5.0.0-rc4
VRT_API_VERSION=5.0.0
VRT_MIGRATION_VERSION=5.0.0
Another option for #414
to answer #332