Skip to content

Conversation

@alexromanov
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #28   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        20        23    +3     
===========================================
  Files              3         4    +1     
  Lines             83        94   +11     
  Branches           4         4           
===========================================
+ Hits              83        94   +11     
Impacted Files Coverage Δ Complexity Δ
...sual_regression_tracker/sdk_java/PathProvider.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...sion_tracker/sdk_java/VisualRegressionTracker.java 100.00% <100.00%> (ø) 18.00 <16.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159be52...9afd2d5. Read the comment docs.

private String apiKey;
private String branchName;
private Boolean enableSoftAssert;
private boolean softAssert;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, keep the old name to be similar to other sdk
in case it needs to be changes we need updated it across all integration libraries

@pashidlos pashidlos merged commit 3de466c into Visual-Regression-Tracker:master Sep 4, 2020
@pashidlos
Copy link
Member

thanks for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants